 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h
| To: | "Petersson, Mats" <Mats.Petersson@xxxxxxx>, "Egger, Christoph" <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Fri, 12 Jan 2007 13:37:14 +0000 |
| Delivery-date: | Fri, 12 Jan 2007 05:36:55 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <907625E08839C4409CE5768403633E0B018E1872@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acc1kOgXXu2QqNVlSqKI0rDbq5BKKwAsCkUgAANs5sA= |
| Thread-topic: | [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 12/1/07 12:01, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:
>> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
>> argument as the first argument. So I remove the consts from
>> the initializer.
>> I replace typeof with __typeof__, which is always available
>> in gcc - it is
>> not, when the -ansi option is used.
>
> And is it expected that Xen will EVER be compiled with -ansi? I think
> there's enough gcc-isms in other places that this will never happen -
> not that it really makes any difference, I'm just curious if anyone
> "cares"...
Yes, I'm going to take the const cleanups but bin the __typeof__ changes.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [RFC] keymap support for PVFB, Daniel P. Berrange |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h, Christoph Egger |
| Previous by Thread: | RE: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h, Petersson, Mats |
| Next by Thread: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
