Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qua

If this was with -Wconst-qual, yes. But didn't we agree that at least for now 
we'll
not add that warning (and hence we also don't absolutely have to change code
only affected by it)? Jan

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 22.12.06 10:40 >>>
Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast
hidden inside the ADDR macro is dropping the const qualifier.

 -- Keir

On 22/12/06 9:31 am, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I object to the change to variable_test_bit() - why is that needed? I had
> specifically
> submitted a patch to get the const qualifier added there. Jan
> 
>>>> "Christoph Egger" <Christoph.Egger@xxxxxxx> 22.12.06 10:05 >>>
> 
> Hi!
> 
> I catched two pieces with debug and crash_debug enabled.
> One of them fixes a build error even without the -Wcast-qual flag.
> 
> Patch attached.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Problem of netfront by network-attach/detach, Kasai Takanori

Next by Date:

Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Christoph Egger

Previous by Thread:

Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Keir Fraser

Next by Thread:

Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Christoph Egger

Indexes:

[Date] [Thread] [Top] [All Lists]