 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag)
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag) |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 22 Dec 2006 09:40:04 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxxxxxxxx> |
| Delivery-date: | Fri, 22 Dec 2006 01:40:35 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <458BB3E5.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcclrShbZzZRcZGgEducAwANk04WTA== |
| Thread-topic: | [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag) |
| User-agent: | Microsoft-Entourage/11.3.2.061213 |
Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast hidden inside the ADDR macro is dropping the const qualifier. -- Keir On 22/12/06 9:31 am, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > I object to the change to variable_test_bit() - why is that needed? I had > specifically > submitted a patch to get the const qualifier added there. Jan > >>>> "Christoph Egger" <Christoph.Egger@xxxxxxx> 22.12.06 10:05 >>> > > Hi! > > I catched two pieces with debug and crash_debug enabled. > One of them fixes a build error even without the -Wcast-qual flag. > > Patch attached. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Christoph Egger |
| Previous by Thread: | [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] two missing bits (was Re: Add -Wcast-qual flag), Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
