xen-devel

[Top] [All Lists]

Re: [Xen-devel] [Patch] cleanup pciback_reset_device

from [Akio Takebe]

[Permanent Link][Original]

To:	Keir Fraser <keir@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	Re: [Xen-devel] [Patch] cleanup pciback_reset_device
From:	Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date:	Mon, 18 Dec 2006 22:26:56 +0900
Cc:	Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Delivery-date:	Mon, 18 Dec 2006 05:25:49 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<C1AC10ED.5FF5%keir@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<C1AC10ED.5FF5%keir@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi, Keir

>On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:
>
>> This patch is for cleanup of pciback_reset_device.
>> is_enabled=0 and is_busmaster=0 are not necessary
>> because pci_disable_device() do them.
>
>If you are zapping the command register then doesn't it makes sense to zap
>the software flags relating to that at the same time, even if that sometimes
>happens to be redundant? It certainly means we can be sure they won't get
>out of sync.
>
I checked linux-2.6.19 and linux-2.6.18, 
both pci_disable_device()s do is_enabled=0 and is_busmaster=0.
I think pci_write_config_word(dev, PCI_COMMAND, 0) is not also necessary,
(though I'm not sure it.)

So I think they in pciback_reset_device() are not necessary.

But if you want to leave it for safe, I agree. :)

Best Regards,

Akio Takebe


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [Patch] cleanup pciback_reset_device, Akio Takebe Re: [Xen-devel] [Patch] cleanup pciback_reset_device, Keir Fraser Re: [Xen-devel] [Patch] cleanup pciback_reset_device, Akio Takebe <=

Previous by Date:	[Xen-devel] [PATCH] [XS-TEST] Support for Xen-API authenticated session, Stefan Berger
Next by Date:	Re: [Xen-devel] Question about evtchn_callback reentry, Keir Fraser
Previous by Thread:	Re: [Xen-devel] [Patch] cleanup pciback_reset_device, Keir Fraser
Next by Thread:	[Xen-devel] [PATCH] bug in default interface number computation, Guillaume Rousse
Indexes:	[Date] [Thread] [Top] [All Lists]