WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] cleanup pciback_reset_device

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] cleanup pciback_reset_device
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Mon, 18 Dec 2006 09:33:33 +0000
Delivery-date: Mon, 18 Dec 2006 01:33:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <2AC72285D84C8Dtakebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Accih5Wm1AapU456Edui4wANk04WTA==
Thread-topic: [Xen-devel] [Patch] cleanup pciback_reset_device
User-agent: Microsoft-Entourage/11.2.5.060620
On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:

> This patch is for cleanup of pciback_reset_device.
> is_enabled=0 and is_busmaster=0 are not necessary
> because pci_disable_device() do them.

If you are zapping the command register then doesn't it makes sense to zap
the software flags relating to that at the same time, even if that sometimes
happens to be redundant? It certainly means we can be sure they won't get
out of sync.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>