WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer

To: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 14 Dec 2006 11:30:13 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Dec 2006 03:30:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200612141059.kBEAxGeO013542@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccfczhSdvQczotmEdu2MgAX8io7RQ==
Thread-topic: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer
User-agent: Microsoft-Entourage/11.2.5.060620
On 14/12/06 10:58, "Atsushi SAKAI" <sakaia@xxxxxxxxxxxxxx> wrote:

>  I searched the code and found
> the code in smp_call_function line337@linux/arch/ia64/kernel/smp.c
>    WARN_ON(irqs_disabled());
> 
> The call trace problem caused by spin_lock_irqsave()
> in xenfb_update_screen@linux/drivers/xen/fbfront/xenfb.c
> 
> Why you need to use spin_lock_irqsave in xenfb_update()?
> I understand the locking but why irqsave is required at this point?

The lock is used in fb_ops, vm_ops and kthread contexts. None of these are
executed in IRQ context so irqsave is not needed. I'll remove it. I'm not
sure whether you can call zap_page_range() even with a spinlock held
though...

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>