 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns
| To: | Keir Fraser <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns |
| From: | Jacob Gorm Hansen <jacobg@xxxxxxx> |
| Date: | Thu, 30 Nov 2006 17:38:36 +0100 |
| Cc: | xen-devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Grzegorz Milos <gm281@xxxxxxxxx> |
| Delivery-date: | Thu, 30 Nov 2006 08:39:06 -0800 |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:sender; b=gDPCsEG1rKqJzOMv1U/3Y+Uysbuf4TyOM1uAKY+Rzba0c1NVvd6L3vWLTWbnY14M8wP6FJUH+LAKtW9w7EDJFI6bCQvbvOFSfzjeXImeQha3t7gPN0wTajNcrDik/UL0N0g0pFL34yi2qIQGnK0Hh/1U+qWIp/DNpx3UaKBgf5I= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C1932CC1.538D%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <C1932CC1.538D%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Wed, 2006-11-29 at 12:25 +0000, Keir Fraser wrote: > On 29/11/06 12:16, "Grzegorz Milos" <gm281@xxxxxxxxx> wrote: > > > The patch looks good to me. I only have one comment: it would be good > > to have unbind_all_ports in the events header file. > > It looked bogus to me. What if event channels are bound/unbound/bound > multiple times during the mini-os lifetime (can't happen right now, but > maybe in future). The port array will overflow. Perhaps it should be a > bitmap instead (set on bind; clear on unbind)? I have attached a new version that uses a bitmap instead and declares unbind_all_ports() in events.h. regards, Jacob
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] rendezvousing all physical CPUs, ron minnich |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] add architecture specific softirq headers, Alex Williamson |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns, Grzegorz Milos |
| Next by Thread: | [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long., Glauber de Oliveira Costa |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
