 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns
| To: | Keir Fraser <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns |
| From: | Grzegorz Milos <gm281@xxxxxxxxx> |
| Date: | Wed, 29 Nov 2006 13:50:48 +0000 |
| Cc: | xen-devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Jacob Gorm Hansen <jacobg@xxxxxxx> |
| Delivery-date: | Wed, 29 Nov 2006 05:50:55 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C1932CC1.538D%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <C1932CC1.538D%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
I guess bitmap would work better. We won't have to rewrite the code
once event channel unbounding is allowed... Shouldn't be too hard.
Thanks Gregor On 29 Nov 2006, at 12:25, Keir Fraser wrote: On 29/11/06 12:16, "Grzegorz Milos" <gm281@xxxxxxxxx> wrote:The patch looks good to me. I only have one comment: it would be good to have unbind_all_ports in the events header file.It looked bogus to me. What if event channels are bound/unbound/boundmultiple times during the mini-os lifetime (can't happen right now, butmaybe in future). The port array will overflow. Perhaps it should be a bitmap instead (set on bind; clear on unbind)? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns, Dietmar Hahn |
|---|---|
| Next by Date: | Re: [Xen-devel] EFER in HVM guests, Jan Beulich |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns, Dietmar Hahn |
| Next by Thread: | Re: [Xen-devel] [PATCH] Allow mini-os to unbind all evtchns, Jacob Gorm Hansen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
