WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel][PATCH][RESEND] PV drivers for HVM guests

To: "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH][RESEND] PV drivers for HVM guests
From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
Date: Fri, 27 Oct 2006 20:43:59 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 27 Oct 2006 04:44:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4535F8F5.E57C.0030.0@xxxxxxxxxx> Your message of Wed, 18 Oct 2006 07:51:45 -0600. <4535F8F5.E57C.0030.0@xxxxxxxxxx> <200610182356.k9INuAF03840@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <45374AE9.E57C.0030.0@xxxxxxxxxx> Your message of Thu, 19 Oct 2006 07:53:42 -0600. <45374AE9.E57C.0030.0@xxxxxxxxxx> <200610201012.k9KACIF29714@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <45389CA5.E57C.0030.0@xxxxxxxxxx> <200610230145.k9N1jGF01307@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <453D8055.4030509@xxxxxxxxxxxxxx> <1161703595.22514.59.camel@xxxxxxxxxxxxxxxxxxxxx> <200610242354.k9ONsIF02543@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <200610250311.k9P3BwF04686@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <1161774212.22514.86.camel@xxxxxxxxxxxxxxxxxxxxx> <200610260013.k9Q0DuF16474@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <200610260358.k9Q3w4F20001@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <1161872106.22514.170.camel@xxxxxxxxxxxxxxxxxxxxx> <00a201c6f96a$811feac0$dab2220a@VF03007L> <1161943070.13318.53.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Ian,

How do you think of this patch?

In general we want to avoid adding compatibility bits to generic code
and confine it to platform-compat.[ch] wherever possible. You have added
code in xencomm.[ch] and hypercall.h which I think we can avoid.

I also try to avoid checking version numbers if I can, preferring to
check for the presence of absence of specific definitions instead. This
is useful when dealing with kernels with backported bits. Unfortunately
it doesn't help with the gfp_t typedef :-( but we'll come to that later.

I've attached my current patch including the ptrace fix from above and
the comments from below. Can you give it a go?

I'll try it.

Thanks

-
Takanori Kasai


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel