WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix tools build on Solaris

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix tools build on Solaris
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 17 Oct 2006 15:01:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 17 Oct 2006 07:02:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061017133945.GA7579@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acbx9MvKCmFY0V3oEduPAgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix tools build on Solaris
User-agent: Microsoft-Entourage/11.2.5.060620


On 17/10/06 14:39, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> Can't you fold TOOL_CFLAGS into CFLAGS? Why do you need a separate variable:
>> does it break the hypervisor build?
> 
> Yes. It's not at all clear why, but the -std=gnu99 causes:

Ah yes, C99 distinguishes initializers from expressions. The cast means that
the compiler interprets the assignment as non-constant. I think the default
mode (-std=gnu89) specifically allows this as a hack, mainly for Linux.
-std=gnu99 is likely to become standard option in future and it probably
wouldn't be hard to fix this.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel