WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix tools build on Solaris

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix tools build on Solaris
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Tue, 17 Oct 2006 14:39:45 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 17 Oct 2006 06:40:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C15A99D2.2A64%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061017131119.GC6012@xxxxxxxxxxxxxxxxxxxx> <C15A99D2.2A64%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, Oct 17, 2006 at 02:31:46PM +0100, Keir Fraser wrote:

> > Many of the tools use C99 features such as bool, or expect certain 
> > functions.
> > Fix the CFLAGS to enable these on Solaris.
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> Can't you fold TOOL_CFLAGS into CFLAGS? Why do you need a separate variable:
> does it break the hypervisor build?

Yes. It's not at all clear why, but the -std=gnu99 causes:

gcc -O1 -fno-omit-frame-pointer -g -std=gnu99 -D_POSIX_C_SOURCE=200112L
-D__EXTENSIONS__ -Wa,--divide -m64 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common
-fno-strict-aliasing -iwithprefix include -Werror -Wno-pointer-arith
-pipe -I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include
-I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-generic
-I/export/johnlev/xen/xen-unstable-daily/xen.hg/xen/include/asm-x86/mach-default
-msoft-float -mno-red-zone -fpic -fno-reorder-blocks
-fno-asynchronous-unwind-tables -g -D__XEN__ -DVERBOSE  -c domctl.c -o
domctl.o
domctl.c: In function `do_domctl':
domctl.c:173: error: initializer element is not constant

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel