WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH/RFC] Wrong account for cpus other than 0 on hotpl

To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH/RFC] Wrong account for cpus other than 0 on hotplug
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 13 Oct 2006 21:33:53 +0100
Delivery-date: Fri, 13 Oct 2006 13:45:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061013175025.GA13539@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbvBuW/JHn5Jlr6Eduu5gANk04WTA==
Thread-topic: [Xen-devel] [PATCH/RFC] Wrong account for cpus other than 0 on hotplug
User-agent: Microsoft-Entourage/11.2.5.060620
On 13/10/06 6:50 pm, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> Is a x86_64 system with multiple CPUs, process accounting is done wrong after
> one cpu goes off and on again (i.e.: a CPU bounded process is running
> but gets 0% cpu for a time, until situation becomes normal again).
> 
> The following patch is a first attempt to fix it. The struct keeps
> zeroed after HYPERVISOR_vcpu_op() is called, thus leading to wrong
> results. Accounting seems to be done right without it. However, I'm not
> 100 % sure we can just poke it out. Comments on this are very welcome.

This patch turns off the missing ticks accounting entirely, as the
runstate_info structure will never be updated. Are you sure this appears to
be an x86_64-specific issue?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>