WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][Take 4] VNC authentification

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][Take 4] VNC authentification
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Tue, 10 Oct 2006 09:04:09 -0500
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Masami Watanabe <masami.watanabe@xxxxxxxxxxxxxx>
Delivery-date: Tue, 10 Oct 2006 07:04:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061010131116.GA22928@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <JG200610050824484.801156@xxxxxxxxxxxxxx> <4524583D.8000109@xxxxxxxxxx> <JJ2006100510281519.8208468@xxxxxxxxxxxxxx> <20061010131116.GA22928@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.7 (X11/20060918)
Daniel P. Berrange wrote:
On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote:
Hi all,

This is take 4 on VNC authentification.

The specification is as mentioned at
http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html
(However, password came to describe plain text)

The difference is follows.
- protocol_authtype() without the necessity was deleted.
- The check on the protocol version was added.
- And, some small modification.

The patch loooks good to me - unless Anthony spots any further issues in
the VNC auth code, I'd say this is worth commiting to xen-unstable.hg
whe 3.0.4 development opens up.

Looks good to me too.  Thanks Masami!

Regards,

Anthony Liguori

Regards,
Dan.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel