WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][Take 4] VNC authentification

To: Masami Watanabe <masami.watanabe@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][Take 4] VNC authentification
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Tue, 10 Oct 2006 14:11:16 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Anthony Liguori <aliguori@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Oct 2006 06:12:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <JJ2006100510281519.8208468@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <JG200610050824484.801156@xxxxxxxxxxxxxx> <4524583D.8000109@xxxxxxxxxx> <JJ2006100510281519.8208468@xxxxxxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote:
> Hi all,
> 
> This is take 4 on VNC authentification.
> 
> The specification is as mentioned at
> http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html
> (However, password came to describe plain text)
> 
> The difference is follows.
> - protocol_authtype() without the necessity was deleted.
> - The check on the protocol version was added.
> - And, some small modification.

The patch loooks good to me - unless Anthony spots any further issues in
the VNC auth code, I'd say this is worth commiting to xen-unstable.hg
whe 3.0.4 development opens up.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel