[Xen-devel] Re: [1/4] [NET] back: Fix off-by-one error in netbk_tx_err

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Jul 03, 2006 at 09:12:32AM +0100, Keir Fraser wrote:
> 
> I wonder if the 'type' field would be better named 'protocol' now? 
> 'Type' is nicely vague though. Also I changed it to uint8_t since it's 
> an enumeration -- should be plenty big enough and leaves us with 8 bits 
> spare in case that's useful in future. Does that seem okay?

Sure that's fine by me.

> Apart from those questions I checked all your patches in. Once they 
> pass our regression tests, and you give the okay, I'll enable the 
> feature negotiation.

Great!

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel