WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenconsole: fix xencons=tty[0-9]+ param

Hi,

On Fri, 2006-06-30 at 18:31 +0100, Keir Fraser wrote:
> On 30 Jun 2006, at 17:56, Mark McLoughlin wrote:
> 
> >     If you boot with e.g. xencons=tty3, then tty1/tty2 aren't valid
> > devices.
> >
> >     Attached patch makes it always create valid devices on tty1-tty63, but
> > all but the one specified by xencons are dummy devices.
> 
> Is your change to ttyS correct for anything other than ttyS0? Looks 
> like you'd incorrectly bind on ttyS0.
>
> Also I see you made a predicate more complicated which is repeated many 
> times. Could you hide it behind a suitably named macro? You may need to 
> make it more complicated still to fix ttyS case...

        Good points. How about this?

Thanks,
Mark.

Attachment: xenconsole.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>