Re: [Xen-devel] [0/5] [NET]: Add TSO support

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Jun 29, 2006 at 02:20:21PM +0100, Keir Fraser wrote:
> 
> If you can recalculate it, why is the field required at all (both in 
> the skbuff and in the netif_tx_extra)? You previously said it was 
> needed because it can't be recalculated (until you get to the 
> segmentation code, which may be very late in packet processing).

It can't be recalculated in general (i.e., in netback).  However, within
each protocol module it can be recalculated.

> We could calculate gso_segs for TCPv4 in netback, which is all we care 
> about right now.

I'd rather not add protocol-specific knowledge to netback.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel