[Xen-devel] Re: [RFC PATCH 24/35] Add support for Xen event channels.

[Andrew Morton <akpm@xxxxxxxx>]

On Tue, 09 May 2006 00:00:24 -0700
Chris Wright <chrisw@xxxxxxxxxxxx> wrote:

> +void __init init_IRQ(void)
> +{
> +     int i;
> +     int cpu;
> +
> +     irq_ctx_init(0);
> +
> +     spin_lock_init(&irq_mapping_update_lock);

May as well initialise this at compile time.

> +     init_evtchn_cpu_bindings();
> +
> +     /* No VIRQ or IPI bindings. */
> +     for (cpu = 0; cpu < NR_CPUS; cpu++) {

Using NR_CPUS is a little...  old-fashioned.  I'd suggest a sweep through
all the Xen code, look for places where it should be using
for_each_foo_cpu().




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel