[Xen-devel] Re: [RFC PATCH 04/35] Hypervisor interface header files.

[Ingo Oeser <ioe-lkml@xxxxxxxxxx>]

Hi Chris,

first of all: Thanks to the Xen-Team for doing this!

On Tuesday, 9. May 2006 09:00, Chris Wright wrote:
> Define macros and inline functions for doing hypercalls into the
> hypervisor.
> +static inline int
> +HYPERVISOR_set_trap_table(
> +     struct trap_info *table)
> +{
> +     return _hypercall1(int, set_trap_table, table);
> +}

This is outright ugly and non-conformant to 
Documentation/CodingStyle Chapter 2

Fixing this also saves some code lines.

It also looks like generated code. Maybe you can fix your generator
instead?


Regards

Ingo Oeser

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel