| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [RFC PATCH 34/35] Add the Xen virtual network device dri
|
To: |
Christoph Hellwig <hch@xxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx |
|
Subject: |
[Xen-devel] Re: [RFC PATCH 34/35] Add the Xen virtual network device driver. |
|
From: |
Chris Wright <chrisw@xxxxxxxxxxxx> |
|
Date: |
Tue, 9 May 2006 16:37:32 -0700 |
|
Delivery-date: |
Tue, 09 May 2006 16:35:23 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20060509115826.GA2213@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20060509084945.373541000@xxxxxxxxxxxx> <20060509085201.446830000@xxxxxxxxxxxx> <20060509115826.GA2213@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.4.2.1i |
* Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> On Tue, May 09, 2006 at 12:00:34AM -0700, Chris Wright wrote:
> > The network device frontend driver allows the kernel to access network
> > devices exported exported by a virtual machine containing a physical
> > network device driver.
>
> Please don't add procfs code to new network drivers. Especially if it's
> oopsable
> like the code in this driver by simple device renaming.
Agreed, no reason to keep the cruft around. I thought I had a comment
of the sort in there.
thanks,
-chris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home