 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] assign_irq_vector adjustments
| To: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] assign_irq_vector adjustments |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 13 Apr 2006 16:22:37 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 13 Apr 2006 08:22:20 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <443E836F.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <443E836F.76E4.0078.0@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 13 Apr 2006, at 15:59, Jan Beulich wrote: In both i386 and x86-64 Linux, using a static variable (and thus having the potential of missing synchronization there, as I suspect exists in native Linux) is not needed with the hypercall approach. In the hypervisor, the patch adds theneeded synchronization. 1. Should you not assign to irq_vector[] and vector_irq[] in Xen with the lock held? Otherwise you may double-allocate if two requests are made concurrently to assign for the same irq (unlikely, but...) 2. Since that'll need a re-send, please also add a Signed-off-by line. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH][Mini-OS] cscope patch, Anthony Liguori |
|---|---|
| Next by Date: | Re: [Xen-devel] Deficiencies in guest bootloader design, Anthony Liguori |
| Previous by Thread: | [Xen-devel] [PATCH] assign_irq_vector adjustments, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] assign_irq_vector adjustments, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
