RE: [Xen-devel] Recent trace patch not arch-neutral

["Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>]

How about just adding "#include <asm/timex.h>" and
stealing linux/include/asm-{i386,x86_64}/timex.h?
Xen/ia64 is already including asm-ia64/timex.h
in other code.

> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
> Sent: Tuesday, November 01, 2005 2:28 AM
> To: Gardner, Robert D
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Magenheimer, Dan (HP Labs 
> Fort Collins); Ian Pratt
> Subject: Re: [Xen-devel] Recent trace patch not arch-neutral
> 
> 
> >  #ifdef x86
> >         rdtscll(rec->cycles);
> >  #endif
> >  #ifdef IA64
> >         __asm__ __volatile ("mov %0=ar.itc;;" : 
> "=r"(rec->cycles) :: 
> > "memory");
> >  #endif
> >
> >  Dan, perhaps you know the nice clean way of doing this 
> sort of thing?
> 
> Okay, let's define the Linux function get_cycles() in 
> include/asm/time.h. So common code can then get at that generic 
> function by including <xen/time.h>. I don't much care for the 
> cycles_t 
> definition but I guess we may as well pull that in as well. Then 
> trace.c can cast to u64 when writing the stamp into the trace record.
> 
>   -- Keir
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel