WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Recent trace patch not arch-neutral

To: Rob Gardner <rob.gardner@xxxxxx>
Subject: Re: [Xen-devel] Recent trace patch not arch-neutral
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 1 Nov 2005 09:27:39 +0000
Cc: "Magenheimer, Dan \(HP Labs Fort Collins\)" <dan.magenheimer@xxxxxx>, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 01 Nov 2005 09:19:31 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4366A81B.2050509@xxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D32E6D0@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <4366A2B4.6070406@xxxxxx> <4366A81B.2050509@xxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

 #ifdef x86
        rdtscll(rec->cycles);
 #endif
 #ifdef IA64
       __asm__ __volatile ("mov %0=ar.itc;;" : "=r"(rec->cycles) :: "memory");
 #endif

 Dan, perhaps you know the nice clean way of doing this sort of thing?

Okay, let's define the Linux function get_cycles() in include/asm/time.h. So common code can then get at that generic function by including <xen/time.h>. I don't much care for the cycles_t definition but I guess we may as well pull that in as well. Then trace.c can cast to u64 when writing the stamp into the trace record.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>