 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of t
| To: | david.nospam.hopwood@xxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Mon, 31 Oct 2005 07:54:07 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Mon, 31 Oct 2005 08:01:18 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <43654ED6.5070604@xxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <436537C9.1090301@xxxxxx> <43654ED6.5070604@xxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 30 Oct 2005, at 22:53, David Hopwood wrote: The sentence "To change the size of an existing allocation, you must firstdeallocate it then reallocate it." should also be removed from the xc_tbuf_set_size doc comment.As a matter of style, I would also suggest moving the tb_init_done check intotb_set_size rather than doing it in the DOM0_TBUF_SET_SIZE handler. Buffer resize was broken on SMP, so I removed it. If anyone actually cares about it then a heavier weight synchronisation will be required (perhaps in the manner of Linux's stop_machine_run), but I'm guessing it's not something anyone cares wildly about right now. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] How to get the physical CPU number, total memory and free memory?, Hongbin Hao |
|---|---|
| Next by Date: | Re: [Xen-devel] unstable network trouble, Gerd Knorr |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers, David Hopwood |
| Next by Thread: | Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers, Rob Gardner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
