WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of t

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers
From: David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>
Date: Sun, 30 Oct 2005 23:02:41 +0000
Delivery-date: Sun, 30 Oct 2005 22:59:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43654ED6.5070604@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <436537C9.1090301@xxxxxx> <43654ED6.5070604@xxxxxxxxxxxxxxxx>
Reply-to: david.nospam.hopwood@xxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
David Hopwood wrote:
> Rob Gardner wrote:
> 
>     //  3. Changing size ==> deallocate and reallocate? Or disallow?
>     //     User can just do a change to 0, then a change to the new size.
> 
> They can, but the interface is slightly simpler if you allow this, and
> the implementation is also slightly shorter because you don't have to
> check for the error, or comment on it:
[...]
> The sentence "To change the size of an existing allocation, you must first
> deallocate it then reallocate it." should also be removed from the
> xc_tbuf_set_size doc comment.

For the implementation I gave, replace it with
"If the call fails (e.g. due to lack of memory), the size may be set to zero."

-- 
David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel