WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] "lock cmpxch8b" and split locks

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
From: "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>
Date: Wed, 5 Oct 2005 14:27:35 -0400
Cc: "Koren, Bradley J" <Bradley.Koren@xxxxxxxxxx>, "Subrahmanian, Raj" <raj.subrahmanian@xxxxxxxxxx>, "Vessey, Bruce A" <Bruce.Vessey@xxxxxxxxxx>
Delivery-date: Wed, 05 Oct 2005 18:25:11 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXJ2nTW5d4lFvKqSSimnEEPAG4l6A==
Thread-topic: [PATCH] "lock cmpxch8b" and split locks
I have been looking at the following bug
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=252
That investigation is still underway. 

While looking at this problem I found that in "lock cmpxch8b
&page->count_info" occurring in "get_page( )", "&page->count_info" is on
a misaligned address. Furthermore the address of "page" is not modulo
64. So the "lock cmpxch8b" can happen across cache lines and lead to a
split lock. On systems which have multiple buses, the atomicity of such
a statement is not assured and can cause synchronization problems. 

I have attached a patch which solves this issue.

Does anyone know if there are other places where the "lock" prefix is
used with a cache misaligned address?
 
Signed off by Aravindh Puthiyaparambil
<aravindh.puthiyaparambil@xxxxxxxxxx>

Attachment: mm.patch
Description: mm.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel