RE: [Xen-devel] [PATCH] tools: Fix network-bridge to work with Gentoo

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> This patch fixes domU networking in Gentoo.  The change to 
> ifup/ifdown (which isn't availabe in Gentoo) prevents the 
> bridge from being setup correctly.  The patch below checks if 
> ifup is avaiable, and if not starts the Gentoo networking scripts.  

Grrrr. At long last we have scripts that work on every version of SuSE,
RHEL, Fedora, and Debain varient I've come across, and then gentoo does
something different...

I don't particularly like this patches approach to fixing the problem,
but then I don't really think its worth a call-out to a separate vendor
script either. 

I'd be inclined to pull the code around the ifup/down into a separate
function and put the vendor workarounds in that to make it explicit.
There's already a bit of ugliness there to cope with setups where the
interface is configured with ip= on the kernel command line rather than
relying on vendor scripts at all. There's also some subtle differences
in the suse/rh ifup/down scripts. As I recall, the SuSE ones always
return a status code of zero even if they fail. Anyhow, all of this is
pretty easy to workaround, we should just pull it into a shell function
for clarity.



Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel