WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools: Fix network-bridge to work with Gentoo

To: Dan Smith <danms@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: Fix network-bridge to work with Gentoo
From: Nivedita Singhvi <niv@xxxxxxxxxx>
Date: Thu, 29 Sep 2005 16:31:23 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Jon Mason <jdmason@xxxxxxxxxx>
Delivery-date: Thu, 29 Sep 2005 23:29:02 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <87hdc3ii4m.fsf@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050929222041.GA26407@xxxxxxxxxx> <87hdc3ii4m.fsf@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20041020)
Dan Smith wrote:
JM> This patch fixes domU networking in Gentoo.  The change to
JM> ifup/ifdown (which isn't availabe in Gentoo) prevents the bridge
JM> from being setup correctly.  The patch below checks if ifup is
JM> avaiable, and if not starts the Gentoo networking scripts.

This brings up the idea about how we can be as distro-friendly as
possible when it comes to network configuration.

How about if we replace the distro-specific bits of the network-bridge
script with calls out to a dedicated one, after we determine which
distro we're on?  That way, we can cleanly add support for a new
distro, without adding a bunch of if-then-elsif's to the main script.

Also, it would allow the distros to easily maintain and plug in their
own scripts to integrate with their network configuration utilities.
That way, they wouldn't have to maintain a patch to the monolithic xen
script.  They could just drop their module into, say,
/etc/xen/scripts/distros/redhat.sh, or something similar.

I think that if we were to make a standard function interface (like
LSB) that the scripts implement, then we could just source them and
use their functions to carry out the wishes of the more complex logic
in the master network-bridge script.

Thoughts?

Here's one vote for doing that - need a clean point to insert customized
pieces.

thanks,
Nivedita



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel