This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] pae: tlbflush linear page table updates

On 10 Aug 2005, at 11:22, Gerd Knorr wrote:

so create_pae_xen_mappings() failure (due to the guest OS trying
illegal things) will *trigger* the error path.  Strange it never
showed up, maybe linux never ever updates l3 entries after
creating them.

I think it preallocates all the L2's so mod_l3_entry probably isn't used. But yes: it looks like I broke it. :-)

BUG_ON(!create_pae_xen_mappings()) is a bad idea, it _can_ fail,
the failure should just be propagated up (so in the end the
hypercall running into this returns some errror) or the domain
should simply be killed ...

The checks that can fail only really belong in alloc_l3_table. An already typed l3 should not need those checks on its highest l3e (mod_l3_entry explicitly disallows meddling with that entry).

 -- Keir

Xen-devel mailing list