Re: [Xen-devel] [RESUBMIT] [PATCH] xen, tools: pincpu use vcpu and cpumap_t

[Mike Wray <mike.wray@xxxxxx>]

Ryan Harper wrote:
> * Mike Wray <mike.wray@xxxxxx> [2005-05-03 12:01]:
>
> > Ryan Harper wrote:
> >
> > > Here is an update to the previous pincpu patches.  This patch updates
> > > the pincpu dom0op to use a cpumap_t pointer, rather than specifying a
> > > size in the interface.  cpumap_t is current typedef'ed to an unsigned
> > > long.  xm list -v now truncates the cpumap field to only show the bits
> > > of the map that are relevant.  That is, if you have four VCPUS, you will
> > > only see the first four bits of the cpumap.  
> > >
> > > This patch compiles against current unstable tree, but I could not test
> > > it as the current unstable tree crashes dom0 when booting domU.  I back
> > > ported the patch to 20050420 snapshot and it worked there.
> > This patch causes the dom0 crash I reported on the current unstable
> > (attached) so it needs fixing before applying.
> I was not able to recreate dom0 crash with the previous patch against
> current nightly snapshot (20050503).  None-the-less addressing some of
> your feedback.  
>
> Attached is an updated patch.
>  o bumped cpumap_t up to u64, per Ian and Keir
>  o Fixed deref of user-space pointer without copy_from_user(), Mike Wray
>  o Added put_domain() in ed > MAX_VIRT_CPUS error path, Mike Wray
Ryan, I just applied your patch and tried to compile it.
I got the following error:

dom0_ops.c: In function `do_dom0_op':
dom0_ops.c:336: structure has no member named `eid'
dom0_ops.c:337: structure has no member named `eid'
make[3]: *** [dom0_ops.o] Error 1
make[3]: Leaving directory 
`/home/mjw/repos-bk/xeno-unstable-xen.patch/xeno-unstable.bk-xen.pin/xen/common'
make[2]: *** 
[/home/mjw/repos-bk/xeno-unstable-xen.patch/xeno-unstable.bk-xen.pin/xen/xen] 
Error 2
make[2]: Leaving directory 
`/home/mjw/repos-bk/xeno-unstable-xen.patch/xeno-unstable.bk-xen.pin/xen'
make[1]: *** [xen] Error 2
make[1]: Leaving directory 
`/home/mjw/repos-bk/xeno-unstable-xen.patch/xeno-unstable.bk-xen.pin'
make: *** [world] Error 2

So it looks like we need to try again.
Apologies if this is because of changes after
you submitted the patch.

I also had two failed hunks, which I fixed manually:

1 out of 1 hunk FAILED -- saving rejects to file xen/arch/x86/domain.c.rej
1 out of 5 hunks FAILED -- saving rejects to file xen/common/dom0_ops.c.rej


Mike

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel