WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH] xen,tools: pincpu use vcpu and cpumap_t

To: "Ryan Harper" <ryanh@xxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] xen,tools: pincpu use vcpu and cpumap_t
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Wed, 27 Apr 2005 01:51:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 27 Apr 2005 00:50:51 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcVKr7Koy8pU/8rkQImhbnqUla5iHwAEg11A
Thread-topic: [PATCH] xen,tools: pincpu use vcpu and cpumap_t
 

>      int err, errno_saved;
>      dom0_op_t op;
> +    u32 vcpu = 0; /* FIXME, hard coded initial pin to vcpu 0 */
> +    cpumap_t cpumap = 1<<cpu;

Ryan,
I haven't looked at the whole patch yet, but this comment worried me, as
it reminded me of a slightly wider change that I think we need to
address at the same time. 

We should remove the initial CPU allocation algorithm from xen
altogether, and leave it to xend (implementing the same ht-aware
algorithm), setting an appropriate pin map for each vcpu. The whole
pining stuff should be removed from xc_domain_create too as it doesn't
belong there.

I'd be inclined to go for something bigger than a long for the size of
the bitmap in the xc interface, even if we only look at the first 32/64
bits within Xen.

Best,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>