Re: [Xen-devel] [PATCH] Guest boot loader support

[Mark Williamson <mark.williamson@xxxxxxxxxxxx>]

Thanks for the patch.

I haven't looked at Jeremy's code but won't the os.path.isfile() break when 
the kernel (and the boot options) are being loaded from within a domain's 
filesystem, rather than dom0?

Cheers,
Mark

On Tuesday 26 April 2005 22:02, aq wrote:
> On 4/27/05, Mark Williamson <mark.williamson@xxxxxxxxxxxx> wrote:
> > > GRUB only looks for menu.lst; distros create symlinks because that's a
> > > terrible name for a config file. In other words, no code should be
> > > opening grub.conf...
> >
> > OK, I've investigated this using my sacrificial FC3 laptop ;-)  I'd not
> > fully investigated this before.
> >
> > Redhat's grub looks for grub.conf and not menu.lst.  Standard grub looks
> > for menu.lst.
> >
> > If the loader is to be flexible for different domU distros, it'd be nice
> > to look for both, in one order or the other.
>
> in that case, this patch is better for you, Mark ;-). Please apply
> this on top of Jeremy's patch.
>
> list of changes:
> - make a dummy file tools/pygrub/src/__init__.py
> - tools/src/pygrub looks for either /boot/grub/menu.lst or
> /boot/grub/grub.conf, in that order.
>
> $ diffstat xen-bootloader.aq2.patch
>  __init__.py |    1 +
>  pygrub      |   11 +++++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
>
> Signed-off-by: Nguyen Anh Quynh <aquynh@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel