WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Unstableness in grant table block drivers

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: Re: [Xen-devel] Unstableness in grant table block drivers
From: Christopher Clark <christopher.w.clark@xxxxxxxxx>
Date: Wed, 20 Apr 2005 11:52:35 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Apr 2005 18:52:25 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=VpUIym8kVHnM0zD+92ECvdiube7ApgoZewfL9lFZXnZnjyw2KgiJF0BYqt8e3TxFu4tW4QfqbZol+4DcIIvpwL050xSWa7+HV7Kn2UzbDyfeceDYQUzRv6ZPAoaGDrjuvOoP9kypekwsrXAROtxP4L4SBtvtaMnCPq7cZvdCB5c=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050418205103.GC19115@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3BD6@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20050416153922.GH27157@xxxxxxxxxx> <eab0875405041809385510d0f9@xxxxxxxxxxxxxx> <20050418205103.GC19115@xxxxxxxxxx>
Reply-to: cwc22@xxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ryan

Many thanks for taking the traces. I've located a bug in the block
backend that may or may not be the required fix -- it's a move of a
single line, see the patch below.

c.

Signed-off-by: Christopher Clark

diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c
b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c
--- a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20
11:31:20 -07:00
+++ b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20
11:31:20 -07:00
@@ -516,11 +516,11 @@

     for ( i = 0; i < nseg; i++ )
     {
+        fas         = req->frame_and_sects[i];
 #ifdef CONFIG_XEN_BLKDEV_GRANT
         seg[i].buf  = (aop[i].u.map_grant_ref.dev_bus_addr << PAGE_SHIFT) |
                       (blkif_first_sect(fas) << 9);
 #else
-        fas          = req->frame_and_sects[i];
         seg[i].buf  = (fas & PAGE_MASK) | (blkif_first_sect(fas) << 9);
         seg[i].nsec = blkif_last_sect(fas) - blkif_first_sect(fas) + 1;
         if ( seg[i].nsec <= 0 )



On 4/18/05, Ryan Harper <ryanh@xxxxxxxxxx> wrote:
> * Christopher Clark <christopher.w.clark@xxxxxxxxx> [2005-04-18 11:39]:
> > Ryan and Anthony: I've attached a patch that I'd like you to apply to
> > your unstable tree -- it just printk's almost everything so I can get
> > an idea of the code path you're running.
> > Alternatively, the three .c files modified by the patch are also
> > attached - they're taken from 2005-04-14 unstable and you should be
> > able to just replace the files in your tree.
> >
> > After changing your tree and rebuilding, please send the console logs
> > from boot onwards for xen/dom0 and domU, in a uniprocessor
> > configuration, both with and without using grant tables for block
> > transport.
> 
> I've applied the patch and I have a bunch of logs.
> 
> 1) domU boot output when dom0up boots domUup
> 2) domU boot output when dom0up boots domUsmp
> 3) xen console output for 1) and 2)
> 4) domU boot output when dom0smp boots domUup
> 5) domU boot output when dom0smp boots domUsmp
> 6) xen console output for 4) and 5)
> 
> In the above cases, dom0up was simulated with maxcpu=1, as I still don't
> have that UP box setup.  If you can't find anything in these logs then
> I'll go get a real UP box and repeat the dumps.
> 
> --
> Ryan Harper
> Software Engineer; Linux Technology Center
> IBM Corp., Austin, Tx
> (512) 838-9253   T/L: 678-9253
> ryanh@xxxxxxxxxx
> 
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel