WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] incorrect memset usage.

To: "Dave Jones" <davej@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] incorrect memset usage.
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Tue, 5 Apr 2005 07:58:52 +0100
Delivery-date: Tue, 05 Apr 2005 07:00:07 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcU5rFNEWjh/WHrjTUaOGfl+IHLI5QAAIysQ
Thread-topic: [Xen-devel] [PATCH] incorrect memset usage.
I think these have already been applied, no?
Thanks,
Ian 

> --- xen-2.0.bk/tools/libxutil/sys_net.c~      2005-03-31 
> 01:11:27.852264603 -0500
> +++ xen-2.0.bk/tools/libxutil/sys_net.c       2005-03-31 
> 01:11:39.320054735 -0500
> @@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
>      static char buf[MAC_LENGTH + 1];
>      int buf_n = sizeof(buf);
>  
> -    memset(buf, buf_n, 0);
> +    memset(buf, 0, buf_n);
>      snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
>               mac[0], mac[1], mac[2],
>               mac[3], mac[4], mac[5]);
> 
> 
> 
> 
> 
> --- xeno-unstable.bk/tools/libxutil/sys_net.c~        
> 2005-03-31 01:18:50.981164430 -0500
> +++ xeno-unstable.bk/tools/libxutil/sys_net.c 2005-03-31 
> 01:19:00.901236556 -0500
> @@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
>      static char buf[MAC_LENGTH + 1];
>      int buf_n = sizeof(buf);
>  
> -    memset(buf, buf_n, 0);
> +    memset(buf, 0, buf_n);
>      snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
>               mac[0], mac[1], mac[2],
>               mac[3], mac[4], mac[5]);
> --- xeno-unstable.bk/tools/ioemu/iodev/harddrv.cc~    
> 2005-03-31 01:19:11.627152192 -0500
> +++ xeno-unstable.bk/tools/ioemu/iodev/harddrv.cc     
> 2005-03-31 01:19:22.851971006 -0500
> @@ -3666,7 +3666,7 @@ ssize_t sparse_image_t::read_page_fragme
>     }
>     else
>     {
> -     memset(buf, read_size, 0);
> +     memset(buf, 0, read_size);
>     }
>   }
>   else
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>