WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-3.4-testing] mce: Replace BUG() with a console warn

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-3.4-testing] mce: Replace BUG() with a console warning in the MCE handler.
From: Xen patchbot-3.4-testing <patchbot@xxxxxxx>
Date: Mon, 09 May 2011 14:55:08 +0100
Delivery-date: Mon, 09 May 2011 06:55:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keith Coleman <keith.coleman@xxxxxxxxxxxxx>
# Date 1304924793 14400
# Node ID 3b39c0fd26a6ee25e953ea0f2852c1253bd94c51
# Parent  14709d196e4389f7b9508df71d54277844550868
mce: Replace BUG() with a console warning in the MCE handler.

If the hardware reports corrected errors that we didn't see through
the status MSRs, complain on the console but don't BUG() the machine.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
xen-unstable changeset:   21757:50cf787b70eb
xen-unstable date:        Fri Jul 09 12:21:31 2010 +0100
---


diff -r 14709d196e43 -r 3b39c0fd26a6 xen/arch/x86/cpu/mcheck/amd_nonfatal.c
--- a/xen/arch/x86/cpu/mcheck/amd_nonfatal.c    Wed Jun 30 18:26:13 2010 +0100
+++ b/xen/arch/x86/cpu/mcheck/amd_nonfatal.c    Mon May 09 03:06:33 2011 -0400
@@ -155,14 +155,19 @@
 
                /* HW does not count *all* kinds of correctable errors.
                 * Thus it is possible, that the polling routine finds an
-                * correctable error even if the HW reports nothing.
-                * However, the other way around is not possible (= BUG).
-                */ 
+                * correctable error even if the HW reports nothing. */ 
                if (counter > 0) {
                        /* HW reported correctable errors,
                         * the polling routine did not find...
                         */
-                       BUG_ON(adjust == 0);
+                       if (adjust == 0) {
+                               printk("CPU counter reports %"PRIu32
+                                       " correctable hardware error%s that %s"
+                                       " not reported by the status MSRs\n",
+                                       counter,
+                                       (counter == 1 ? "" : "s"),
+                                       (counter == 1 ? "was" : "were"));
+                       }
                        /* subtract 1 to not double count the error 
                         * from the polling service routine */ 
                        adjust += (counter - 1);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-3.4-testing] mce: Replace BUG() with a console warning in the MCE handler., Xen patchbot-3 . 4-testing <=