Re: [Xen-ia64-devel][Patch]Add two PAL calls which fix SMP windows installation crashing bug

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-03-27 at 09:18 +0800, Zhang, Xing Z wrote:
> Add two PAL calls -- PAL_LOGICAL_TO_PHYSICAL and PAL_FIXED_ADDR.
> 
> These PAL calls are invoked by SMP windows installation code.
> 
> The patch fix SMP windows installation crashing bug.

   This seems incomplete.  Doesn't a PAL_LOGICAL_TO_PHYSICAL
implementation imply we also need a working SAL_PHYSICAL_ID_INFO?  I
also get error messages about unimplemented PAL call #43
(PAL_CACHE_SHARED_INFO) when I try this.  According to the spec, this
call is required for any system reporting more than one logical
processor on a physical processor package.

   I think we should implement these calls, but why would we represent a
vCPU as anything more than a single processor per socket?  If we pretend
everything is a dual core processor with threads disabled, we get into
issues of reporting the correct socket number and thread number.  It
feels like it's just adding complication for no benefit.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel