|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] Re: [Qemu-devel] [PATCH V2 01/10] configure: Introduce	--ena
 
On 19 October 2011 14:56, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> +if test "$xen_pci_passthrough" != "no"; then
> +  if test "$xen" = "yes" -a "$linux" = "yes"; then
> +    xen_pci_passthrough=yes
> +  else
> +    if test "$xen_pci_passthrough" = "yes"; then
> +      feature_not_found "Xen PCI Passthrough without Xen or not on linux"
> +    fi
> +    xen_pci_passthrough=no
> +  fi
> +fi
The -a flag to test is obsolete -- don't use it in new code.
This is a bit of a misuse of the feature_not_found function IMHO.
(Also, Linux needs a capital letter.)
-- PMM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |