Re: [Xen-devel] [PATCH 4/6] x86: split struct domain

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Apr 5, 2011 at 9:21 AM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
> This is accomplished by converting a couple of embedded arrays (in one
> case a structure containing an array) into separately allocated
> pointers, and (just as for struct arch_vcpu in a prior patch) overlaying
> some PV-only fields with HVM-only ones.
>
> One particularly noteworthy change in the opposite direction is that of
> PITState - this field so far lived in the HVM-only portion, but is being
> used by PV guests too, and hence needed to be moved out of struct
> hvm_domain.
>
> The change to XENMEM_set_memory_map (and hence libxl__build_pre() and
> the movement of the E820 related pieces to struct pv_domain) are subject
> to a positive response to a query sent to xen-devel regarding the need
> for this to happen for HVM guests (see
> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01848.html).

Just a heads-up, XenServer apparently does call XENMEM_set_memory_map
for HVM guests.  I'll take a look and see if it's actually necessary
or not, and if so, revert the part of the patch that moves the e820
stuff into a pv-specific structure.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel