WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] parse_config_data()...

To: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
Subject: Re: [Xen-devel] parse_config_data()...
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 23 Sep 2011 11:25:08 +0100
Cc: "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Stefano
Delivery-date: Fri, 23 Sep 2011 03:26:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110922190135.44aedd25@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110922113048.2d02f126@xxxxxxxxxxxxxxxxxxxx> <20110922190135.44aedd25@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 23 Sep 2011, Mukesh Rathor wrote:
> On Thu, 22 Sep 2011 11:30:48 -0700
> Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> 
> > Hi Stefano,
> > 
> > In parse_config_data():
> > 
> >     init_create_info(c_info);  <--- sets hvm and hap to 1, then:.
> > 
> >     c_info->hvm = 0;
> >     if (!xlu_cfg_get_string (config, "builder", &buf) &&
> >         !strncmp(buf, "hvm", strlen(buf)))
> >         c_info->hvm = 1;
> > 
> >     if (!xlu_cfg_get_long (config, "hap", &l))    <-------- already 1
> >         c_info->hap = l;  <--- letter 'el'
> > 
> > 
> > no big deal, but just confusing for someone reading the code...
> > 
> > thanks,
> > Mukesh
> 
> Never mind, my bad... thanks, Mukesh
> 

no problems :-)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>