Re: [Xen-devel] Minor bug fix in libxl_pci.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-08-18 at 09:45 +0100, Kaushik Kumar Ram wrote:
> Add missing 'break' statement.
> 
> Without the 'break', assigning a pci device to a PV guest results in an abort,
> since the code always falls through to the default abort case in the switch
> statement.
> 
> Signed-off-by: Kaushik Kumar Ram <kaushik@xxxxxxxx>

Uh, absolutely right, my bad! (cset 23714:97cb910d39b3)

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> diff -r 8d6edc3d26d2 -r 7344ec5fcc45 tools/libxl/libxl_pci.c
> --- a/tools/libxl/libxl_pci.c   Sat Aug 13 10:14:58 2011 +0100
> +++ b/tools/libxl/libxl_pci.c   Thu Aug 18 03:42:11 2011 -0500
> @@ -696,6 +696,7 @@ static int do_pci_add(libxl__gc *gc, uin
>              }
>          }
>          fclose(f);
> +       break;
>      }
>      default:
>          abort();
> 
> 
> --Kaushik
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel