WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Minor bug fix in libxl_pci.c

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Minor bug fix in libxl_pci.c
From: Kaushik Kumar Ram <kaushik@xxxxxxxx>
Date: Thu, 18 Aug 2011 03:45:08 -0500
Delivery-date: Thu, 18 Aug 2011 01:45:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Add missing 'break' statement.

Without the 'break', assigning a pci device to a PV guest results in an abort,
since the code always falls through to the default abort case in the switch
statement.

Signed-off-by: Kaushik Kumar Ram <kaushik@xxxxxxxx>

diff -r 8d6edc3d26d2 -r 7344ec5fcc45 tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c   Sat Aug 13 10:14:58 2011 +0100
+++ b/tools/libxl/libxl_pci.c   Thu Aug 18 03:42:11 2011 -0500
@@ -696,6 +696,7 @@ static int do_pci_add(libxl__gc *gc, uin
             }
         }
         fclose(f);
+       break;
     }
     default:
         abort();


--Kaushik
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>