This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Mon, 27 Jun 2011 18:04:48 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 27 Jun 2011 10:07:29 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=fD2VSyLmpIhxJhaCReztyNfqGAFZ1h4dikAJH2jFGWE=; b=WnhMqf3vyE8fKnJMVjG5TRtxwfIwANySDrCs4YFPiPmPt+TLt35Ws3OtAUG9WoNRoL U8E9AtsuYKg1nI/s+MKb5uDRGiRMhSSXvJk0rfvzUSTRLH/q9fzbUVSzmwMKjrslKY4K x5F8Y+NyhujVGx+rriOJN8752+zqQtX4NgKhk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=lvXYuRfPPrATtKiWEnPhkDSDAqlHxo7MswrKd4eumF1unMJKDJCYO/Qt7Xblqrn/ls UWbF1PsEQoOAhyEoyxx9xsLSF61H5qvte6Jqg5guoKOe+BzEqkKe6gWX/q4F0g3MQXz1 vsaOqkTx6vT47K/VUreNNw3qbuCgotveTSx/4=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19976.44330.128977.805588@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1309187551-21538-1-git-send-email-anthony.perard@xxxxxxxxxx> <1309187551-21538-4-git-send-email-anthony.perard@xxxxxxxxxx> <19976.44330.128977.805588@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, Jun 27, 2011 at 17:17, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Anthony PERARD writes ("[Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP 
> client"):
>> QMP stands for QEMU Monitor Protocol and it is used to query information
>> from QEMU or to control QEMU.
>> This implementation will ask QEMU the list of chardevice and store the
>> path to serial0 in xenstored. So we will be able to use xl console with
>> QEMU upstream.
> Can I make a suggestion ?  I think the formulaic json parser stuff
> could usefully live in a separate file.

Ok, I will cut the file.

>> +static inline yajl_gen_status yajl_gen_asciiz(yajl_gen hand, const
> char *str)
> Isn't this a hostage to fortune ?  yajl may grow an identically-named
> function in which case this will no longer build.

Maybe. I will rename to libxl__yajl_gen_asciiz.

>> +#ifdef DEBUG_ANSWER
>> +    if (qmp->g)
>> +        yajl_gen_free(qmp->g);
>> +#endif
> Can this #ifdef not be shuffled off somewhere ?  Ie, make a debug
> function (or macro) which we call unconditionally.

Ok, I will remove all the #ifdef debug_answer.

> The rest looks plausible.

Thanks for the review,

Anthony PERARD

Xen-devel mailing list