This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client

Anthony PERARD writes ("[Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP 
> QMP stands for QEMU Monitor Protocol and it is used to query information
> from QEMU or to control QEMU.
> This implementation will ask QEMU the list of chardevice and store the
> path to serial0 in xenstored. So we will be able to use xl console with
> QEMU upstream.

Can I make a suggestion ?  I think the formulaic json parser stuff
could usefully live in a separate file.

> +static inline yajl_gen_status yajl_gen_asciiz(yajl_gen hand, const
char *str)

Isn't this a hostage to fortune ?  yajl may grow an identically-named
function in which case this will no longer build.

> +#ifdef DEBUG_ANSWER
> +    if (qmp->g)
> +        yajl_gen_free(qmp->g);
> +#endif

Can this #ifdef not be shuffled off somewhere ?  Ie, make a debug
function (or macro) which we call unconditionally.

The rest looks plausible.


Xen-devel mailing list