[Xen-devel] Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node

[Peter Maydell <peter.maydell@xxxxxxxxxx>]

On 24 June 2011 17:35,  <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> +out_error:
> +    qemu_free(blkdev->params);
> +    qemu_free(blkdev->mode);
> +    qemu_free(blkdev->type);
> +    qemu_free(blkdev->dev);
> +    qemu_free(blkdev->devtype);
> +    return -1;

It occured to me that could result in a double-free if it's
possible to call init again (or to call free) after the init
routine has returned failure. I don't know enough about the
Xen device lifecycle to know if that's possible, though -- is it?

thanks
-- PMM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel