This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools: fix build after recent xenpaging changes

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: fix build after recent xenpaging changes
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 24 Jun 2011 16:35:12 +0200
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 24 Jun 2011 07:38:49 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1308926113; l=554; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=NPoNYfYupkMGFj+ZYnows18sLao=; b=xTaF4+v7vLybPzM4HDwAhA3Lz+dbVaJPJw99ofb/TqV5lig2xZPeD9GPFIrmllJrF9+ QLT6OS7nLcE3cUOjcM9keyHeW+Z4CxwgkqYCAwt+lS0Etr1XvWFQ0lX3D6uBhox8YXXkI u/oYnRqAaQ4tpKkVbD+/j9xWwPeTFJKZYKU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1308925806.32717.119.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110624121613.GA17634@xxxxxxxxxxxxxxxxxxxxxxx> <1308918826.32717.85.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110624133201.GB27793@xxxxxxxxx> <1308923299.32717.109.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110624135708.GA28839@xxxxxxxxx> <1308925806.32717.119.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-12-30)
On Fri, Jun 24, Ian Campbell wrote:

> > The break exits the for() loop, not the while(1). In the next iteration
> > page 1 may still be in paging->bitmap and tried again.
> I'd missed the interrupted -> 1 in the while loop. I presume there is
> some other exit condition which triggers once everything has been paged
> back in and actually causes the daemon to exit?

If the for() loop found nothing, then this triggers:

775             /* If no more pages to process, exit loop */
776             if ( i == paging->domain_info->max_pages )
777                 break;


Xen-devel mailing list