This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools: fix build after recent xenpaging changes

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: fix build after recent xenpaging changes
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 24 Jun 2011 15:57:08 +0200
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 24 Jun 2011 07:03:21 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1308923829; l=637; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=4lUF+DEb3qH/CGdwufZ9bE2vJCA=; b=JM3rx2Tl4c6uTIX+trAyy4EywNPwm/5bQqjFuwKa4UM5tGTLU1NVfa52vpoPhsPjriF sb9p6k6N+FhYQG+W7nw1svXii/njPL0LA28Sbt2YYXblkCT8gb8YHvWP2H1o9bOVOVvCO WhShJqKQwC9R6Q00qYp5YW+XIhjox0//xgU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1308923299.32717.109.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110624121613.GA17634@xxxxxxxxxxxxxxxxxxxxxxx> <1308918826.32717.85.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110624133201.GB27793@xxxxxxxxx> <1308923299.32717.109.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-12-30)
On Fri, Jun 24, Ian Campbell wrote:

> In fact since the page-in thread is doing relatively expensive work I'd
> expect that the trigger loop would get to run several iterations for
> each time the page-in loop ran..

That did not happen for me, I will think about it.

> > If the caller of page_in_trigger will find the gfn is still in paging
> > state, it will just try again.
> I don't see where it would go back and try page 1 again if it gets
> missed (as in the above example)

The break exits the for() loop, not the while(1). In the next iteration
page 1 may still be in paging->bitmap and tried again.


Xen-devel mailing list