WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] make tools ERROR in latest xen-unstable.hg

To: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>, "Ren, Yongjie" <yongjie.ren@xxxxxxxxx>
Subject: RE: [Xen-devel] make tools ERROR in latest xen-unstable.hg
From: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>
Date: Fri, 17 Jun 2011 15:58:37 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 17 Jun 2011 01:01:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DFAFBDA.8070001@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CE59C043D0EC3349B2BF41C0EC72229B12D187CB5E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4DFAFBDA.8070001@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwsvPua4loS2jaERMuThZ4ioNsBFQABxBTw
Thread-topic: [Xen-devel] make tools ERROR in latest xen-unstable.hg
So, will you submit a patch to fix it?

best regards
yang


> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Vincent
> Hanquez
> Sent: Friday, June 17, 2011 3:02 PM
> To: Ren, Yongjie
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] make tools ERROR in latest xen-unstable.hg
> 
> On 06/17/2011 07:29 AM, Ren, Yongjie wrote:
> > Hi all,
> > In our test, xen-unstable build fails. When running 'make tools', I got the
> following error. Do you have the same issue ?
> > xl_cmdimpl.c: In function 'acquire_lock':
> > xl_cmdimpl.c:202: error: 'O_CLOEXEC' undeclared (first use in this
> > function)
> > xl_cmdimpl.c:202: error: (Each undeclared identifier is reported only
> > once
> > xl_cmdimpl.c:202: error: for each function it appears in.)
> 
> I've just got bitten by that in another repository [1] looks like you use an 
> old
> distribution (flags that appears in the kernel in 2.6.23).
> 
> The solution is simple since there's no need for the atomicity: it consists in
> removing O_CLOEXEC and switching to fcntl(fd, F_SETFD,
> FD_CLOEXEC)
> 
> [1]
> https://github.com/xen-org/xen-api-libs/commit/523e1c5364e11e0d5bbd5308
> 988c263392df0559
> 
> --
> Vincent
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel