This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] make tools ERROR in latest xen-unstable.hg

To: "Ren, Yongjie" <yongjie.ren@xxxxxxxxx>
Subject: Re: [Xen-devel] make tools ERROR in latest xen-unstable.hg
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Fri, 17 Jun 2011 08:01:46 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 17 Jun 2011 00:05:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CE59C043D0EC3349B2BF41C0EC72229B12D187CB5E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <CE59C043D0EC3349B2BF41C0EC72229B12D187CB5E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110606 Icedove/3.1.10
On 06/17/2011 07:29 AM, Ren, Yongjie wrote:
Hi all,
In our test, xen-unstable build fails. When running 'make tools', I got the 
following error. Do you have the same issue ?
xl_cmdimpl.c: In function 'acquire_lock':
xl_cmdimpl.c:202: error: 'O_CLOEXEC' undeclared (first use in this function)
xl_cmdimpl.c:202: error: (Each undeclared identifier is reported only once
xl_cmdimpl.c:202: error: for each function it appears in.)

I've just got bitten by that in another repository [1]
looks like you use an old distribution (flags that appears in the kernel in 2.6.23).

The solution is simple since there's no need for the atomicity: it consists in removing O_CLOEXEC and switching to fcntl(fd, F_SETFD, FD_CLOEXEC)

[1] https://github.com/xen-org/xen-api-libs/commit/523e1c5364e11e0d5bbd5308988c263392df0559


Xen-devel mailing list