This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Wed, 15 Jun 2011 09:39:07 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: Jan, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx>, Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Wed, 15 Jun 2011 09:39:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DF8AE57.2030800@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307984567@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <3ad737eb0a8ded1b8306.1307984573@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301E728131A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4DF8AE57.2030800@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwrXRyl4f5MGz9nSL2/Y2BH1NjjYAAHPuYQ
Thread-topic: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op
> Well spotted - I missed that.  My suggestion would be to remove the
> check for eim and deal with it in the relevant disable_intremap and
> disable_qi functions.  My feeling is that a call to "iommu_disable_IR"
> should be able to deal whether or not you have eim.

I agree with your suggestion of not checking for EIM in iommu_disable_IR().


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>