This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Tue, 14 Jun 2011 15:15:29 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: Keir Fraser <keir.xen@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 14 Jun 2011 15:16:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <3ad737eb0a8ded1b8306.1307984573@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307984567@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <3ad737eb0a8ded1b8306.1307984573@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acwp7KE7cccHi0cVSHuuBQkZPavgjQA8apnQ
Thread-topic: [Xen-devel] [PATCH 6 of 7] IOMMU: add crash_shutdown iommu_op
+static void vtd_crash_shutdown(void)
+    struct acpi_drhd_unit *drhd;
+    struct iommu *iommu;
+    if ( !iommu_enabled )
+        return;
+    iommu_flush_all();
+    for_each_drhd_unit ( drhd )
+    {
+        iommu = drhd->iommu;
+        iommu_disable_translation(iommu);
+    }
+    iommu_disable_x2apic_IR();

Iommu_disable_x2apic_IR() check for iommu_supports_eim() before entering.  What 
happens when x2apic is not enabled but interrupt remapping is enabled?

Maybe you should just create disable_intremap() and disable_qi() functions and 
call from vtd_crash_shutdown() and iommu_disable_x2apic_IR().


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>